Review Request 125314: KBuildSycocaProgressDialog: run kbuildsycoca5 with QProcess.

[Albert Astals Cid]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125314/#review85694
-----------------------------------------------------------

Ship it!


Ship It!

- Albert Astals Cid


On set. 19, 2015, 8:21 p.m., David Faure wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/125314/
> -----------------------------------------------------------
> 
> (Updated set. 19, 2015, 8:21 p.m.)
> 
> 
> Review request for KDE Frameworks and Albert Astals Cid.
> 
> 
> Bugs: 166792
>     https://bugs.kde.org/show_bug.cgi?id=166792
> 
> 
> Repository: kio
> 
> 
> Description
> -------
> 
> The dbus-callback stuff from kded is unreliable and unnecessary.
> 
> And meanwhile I made kbuildsycoca5 work well when called more
> than once, the second instance will wait for the first one
> and then check if there's anything else to do, otherwise quit early.
> 
> Change-Id: I24f62cf1015bdbab1778245f4221f03f40a9bd0f
> BUGS: 235486, 166792
> REVIEW: 125314
> FIXED-IN: 5.15
> 
> 
> Diffs
> -----
> 
>   src/widgets/kbuildsycocaprogressdialog.h 88c5087990c01725e065fc650e63de246b3032e1 
>   src/widgets/kbuildsycocaprogressdialog.cpp 78d23dfda174f195e4c7fdfc1e128e83194326f3 
> 
> Diff: https://git.reviewboard.kde.org/r/125314/diff/
> 
> 
> Testing
> -------
> 
> kpropertiesdialogtest <path to app desktop file>, changing the comment, clicking OK.
> 
> 
> Thanks,
> 
> David Faure
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20150920/9a034caf/attachment.html>