Review Request 125279: KSycoca: change DB filename to include language and sha1 of the dirs it's built from.

[David Faure]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125279/
-----------------------------------------------------------

(Updated Sept. 19, 2015, 7:34 p.m.)


Review request for KDE Frameworks and Albert Astals Cid.


Changes
-------

use hardlink on unix, copy on windows


Repository: kservice


Description (updated)
-------

This will prevent sycoca-rebuild ping-pong if two apps with different settings
would share the same file (and keep finding that it's wrong for them),
and it fixes Albert's bug that "LANG=de kcmshell5 --list" doesn't show German
translations for the strings coming from desktop files.

To avoid migration issues, the old filename ksycoca5 is still provided, as a hardlink
so that mmap works.

REVIEW: 125279


Diffs (updated)
-----

  autotests/ksycocatest.cpp 7c2d91e056726540b8a3a5c679d9b2a93f023c50 
  docs/kbuildsycoca5/man-kbuildsycoca5.8.docbook d7f85813b1956b578600b4fbd147b3ac649b470c 
  src/sycoca/kbuildsycoca.cpp d3328f05bf761979bdffaa19f771e949759d6b76 
  src/sycoca/ksycoca.h a78e90876ed758093070989ab166959e0ea6c0e3 
  src/sycoca/ksycoca.cpp a2b70407db3778196216969932c995c11f44fcf6 

Diff: https://git.reviewboard.kde.org/r/125279/diff/


Testing
-------

unittests, after adjusting ksycocatest which was checking for the old behavior (same file).

Albert: there we are, finally ;) Your bug should be fixed (I don't have translations installed to test it, though). Thanks for all the reviews!


Thanks,

David Faure

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20150919/6c6907a7/attachment.html>