<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/125279/">https://git.reviewboard.kde.org/r/125279/</a>
</td>
</tr>
</table>
<br />
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: 1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
<div>Review request for KDE Frameworks and Albert Astals Cid.</div>
<div>By David Faure.</div>
<p style="color: grey;"><i>Updated Sept. 19, 2015, 7:34 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Changes</h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">use hardlink on unix, copy on windows</pre>
</td>
</tr>
</table>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
kservice
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description (updated)</h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This will prevent sycoca-rebuild ping-pong if two apps with different settings
would share the same file (and keep finding that it's wrong for them),
and it fixes Albert's bug that "LANG=de kcmshell5 --list" doesn't show German
translations for the strings coming from desktop files.
To avoid migration issues, the old filename ksycoca5 is still provided, as a hardlink
so that mmap works.
REVIEW: 125279</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">unittests, after adjusting ksycocatest which was checking for the old behavior (same file).</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Albert: there we are, finally ;) Your bug should be fixed (I don't have translations installed to test it, though). Thanks for all the reviews!</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> (updated)</h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>autotests/ksycocatest.cpp <span style="color: grey">(7c2d91e056726540b8a3a5c679d9b2a93f023c50)</span></li>
<li>docs/kbuildsycoca5/man-kbuildsycoca5.8.docbook <span style="color: grey">(d7f85813b1956b578600b4fbd147b3ac649b470c)</span></li>
<li>src/sycoca/kbuildsycoca.cpp <span style="color: grey">(d3328f05bf761979bdffaa19f771e949759d6b76)</span></li>
<li>src/sycoca/ksycoca.h <span style="color: grey">(a78e90876ed758093070989ab166959e0ea6c0e3)</span></li>
<li>src/sycoca/ksycoca.cpp <span style="color: grey">(a2b70407db3778196216969932c995c11f44fcf6)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/125279/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>