Review Request 125251: KSycoca optimization: only watch the file if the app connects to databaseChanged()

David Faure faure at kde.org
Wed Sep 16 20:59:08 UTC 2015


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125251/
-----------------------------------------------------------

(Updated Sept. 16, 2015, 8:59 p.m.)


Status
------

This change has been marked as submitted.


Review request for KDE Frameworks and Albert Astals Cid.


Changes
-------

Submitted with commit 358458ff4e64a0652c8310acc3f1ef0a5d287a3c by David Faure to branch master.


Repository: kservice


Description
-------

KSycoca optimization: only watch the file if the app connects to databaseChanged()


Diffs
-----

  src/sycoca/ksycoca.h cec43a4431cd90e1590f50bf8424f395541a0847 
  src/sycoca/ksycoca.cpp 205d00c14e330db719acf091f5206fdb519d4c63 
  src/sycoca/ksycoca_p.h dcd788ce9c3fd45e0a04ee936f4dbdd2e4cd872b 

Diff: https://git.reviewboard.kde.org/r/125251/diff/


Testing
-------

Unit tests still pass (including those who do connect to that signal).


Thanks,

David Faure

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20150916/165181a1/attachment.html>


More information about the Kde-frameworks-devel mailing list