Review Request 125251: KSycoca optimization: only watch the file if the app connects to databaseChanged()

[Albert Astals Cid]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125251/#review85511
-----------------------------------------------------------

Ship it!


Ok, then, makes sense.

- Albert Astals Cid


On set. 15, 2015, 11:01 p.m., David Faure wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/125251/
> -----------------------------------------------------------
> 
> (Updated set. 15, 2015, 11:01 p.m.)
> 
> 
> Review request for KDE Frameworks and Albert Astals Cid.
> 
> 
> Repository: kservice
> 
> 
> Description
> -------
> 
> KSycoca optimization: only watch the file if the app connects to databaseChanged()
> 
> 
> Diffs
> -----
> 
>   src/sycoca/ksycoca.h cec43a4431cd90e1590f50bf8424f395541a0847 
>   src/sycoca/ksycoca.cpp 205d00c14e330db719acf091f5206fdb519d4c63 
>   src/sycoca/ksycoca_p.h dcd788ce9c3fd45e0a04ee936f4dbdd2e4cd872b 
> 
> Diff: https://git.reviewboard.kde.org/r/125251/diff/
> 
> 
> Testing
> -------
> 
> Unit tests still pass (including those who do connect to that signal).
> 
> 
> Thanks,
> 
> David Faure
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20150916/1827705e/attachment-0001.html>