Review Request 125104: When using scalable icons use still only use sizes defined by index metadata

[David Edmundson]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125104/
-----------------------------------------------------------

(Updated Sept. 11, 2015, 8:28 p.m.)


Status
------

This change has been marked as submitted.


Review request for KDE Frameworks, andreas kainz and Christoph Feck.


Changes
-------

Submitted with commit ec3c6892413c90e01f88abc7b3fc16924b69ffd3 by David Edmundson to branch master.


Repository: kiconthemes


Description
-------

Icon metadata contains an entry of what sizes should be used for toolbars.

If a folder for an icon size contains scalable icons, the current code will list every possible pixel size which could possibly be used. (The toolbar then has code to reduce this back down to 10 "random" entries!)

Breeze icon designers say this is undesirable as it makes the
ToolbarSizes config entry redundnant and despite being SVGs they are
still designed to be rendered at specific pixel sizes.


Diffs
-----

  src/kicontheme.cpp d29f82add93b97f8307a370cf3409fede38df865 

Diff: https://git.reviewboard.kde.org/r/125104/diff/


Testing
-------

Right click on a toolbar in a KF5 app, only lists relevant sizes.


Thanks,

David Edmundson

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20150911/b6293c85/attachment.html>