Review Request 125104: When using scalable icons use still only use sizes defined by index metadata

[andreas kainz]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125104/#review85013
-----------------------------------------------------------

Ship it!


Ship It!

- andreas kainz


On Sept. 8, 2015, 2:27 p.m., David Edmundson wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/125104/
> -----------------------------------------------------------
> 
> (Updated Sept. 8, 2015, 2:27 p.m.)
> 
> 
> Review request for KDE Frameworks, andreas kainz and Christoph Feck.
> 
> 
> Repository: kiconthemes
> 
> 
> Description
> -------
> 
> Icon metadata contains an entry of what sizes should be used for toolbars.
> 
> If a folder for an icon size contains scalable icons, the current code will list every possible pixel size which could possibly be used. (The toolbar then has code to reduce this back down to 10 "random" entries!)
> 
> Breeze icon designers say this is undesirable as it makes the
> ToolbarSizes config entry redundnant and despite being SVGs they are
> still designed to be rendered at specific pixel sizes.
> 
> 
> Diffs
> -----
> 
>   src/kicontheme.cpp d29f82add93b97f8307a370cf3409fede38df865 
> 
> Diff: https://git.reviewboard.kde.org/r/125104/diff/
> 
> 
> Testing
> -------
> 
> Right click on a toolbar in a KF5 app, only lists relevant sizes.
> 
> 
> Thanks,
> 
> David Edmundson
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20150908/2dd3e163/attachment.html>