Review Request 125148: Call parent ::event()

Albert Astals Cid aacid at kde.org
Fri Sep 11 12:29:07 UTC 2015


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125148/
-----------------------------------------------------------

(Updated Sept. 11, 2015, 12:29 p.m.)


Status
------

This change has been marked as submitted.


Review request for KDE Frameworks.


Changes
-------

Submitted with commit 1cc135709206156cb45f512562fca1d864dea362 by Albert Astals Cid to branch master.


Repository: kdelibs4support


Description
-------

::event() implementations need to call the parent ::event() otherwise things like deleteLater which is implemented in QObject::event won't work

In this case it probably doesn't matter, but it's always good to have "good code"


Diffs
-----

  src/kdecore/k3resolver.cpp 12b84df 

Diff: https://git.reviewboard.kde.org/r/125148/diff/


Testing
-------


Thanks,

Albert Astals Cid

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20150911/54f14418/attachment.html>


More information about the Kde-frameworks-devel mailing list