Review Request 125148: Call parent ::event()

[David Faure]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125148/#review85155
-----------------------------------------------------------

Ship it!


Ship It!

- David Faure


On Sept. 10, 2015, 9:12 p.m., Albert Astals Cid wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/125148/
> -----------------------------------------------------------
> 
> (Updated Sept. 10, 2015, 9:12 p.m.)
> 
> 
> Review request for KDE Frameworks.
> 
> 
> Repository: kdelibs4support
> 
> 
> Description
> -------
> 
> ::event() implementations need to call the parent ::event() otherwise things like deleteLater which is implemented in QObject::event won't work
> 
> In this case it probably doesn't matter, but it's always good to have "good code"
> 
> 
> Diffs
> -----
> 
>   src/kdecore/k3resolver.cpp 12b84df 
> 
> Diff: https://git.reviewboard.kde.org/r/125148/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Albert Astals Cid
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20150911/89884a86/attachment.html>