Review Request 125869: Convert all io slave .protocol data to json and embed it.

[David Faure]

> On Oct. 30, 2015, 7:29 a.m., David Faure wrote:
> > src/ioslaves/trash/trash.json, line 6
> > <https://git.reviewboard.kde.org/r/125869/diff/1/?file=413338#file413338line6>
> >
> >     That doesn't look very English to me ;)
> >     
> >     The original is:
> >     
> >     ExtraNames=Original Path,Deletion Date
> >     
> >     But this shows a problem: missing support for translating this field. We didn't realize there was a translatable field in these files. Please add support for translations, like was done for other json files (talk to e.g. Luigi Toscano).
> 
> Christoph Cullmann wrote:
>     Hmm, then we have a problem: We can no longer convert the stuff and remove the .protocol files, or?
> 
> Christoph Cullmann wrote:
>     Ok, did read up a bit, ExtraNames seems to be the only translated thing (at least if I read KProtocolInfo docs the right way).
>     Can do the same trick as desktop2json does for that. Seems not that hard.
>     But then we need CMake stuff for it, or? To convert on the fly to have translations using the .protocol files like we have ATM in the .desktop files for the plugin stuff.

I don't think you're looking in the right direction. AFAIK there is support for translating json files directly in l10n (json -> po -> json) these days. As I said, please ask Luigi or maybe Albert.


- David


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125869/#review87721
-----------------------------------------------------------


On Oct. 29, 2015, 5:03 p.m., Christoph Cullmann wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/125869/
> -----------------------------------------------------------
> 
> (Updated Oct. 29, 2015, 5:03 p.m.)
> 
> 
> Review request for KDE Frameworks, Alex Richardson and David Faure.
> 
> 
> Repository: kio
> 
> 
> Description
> -------
> 
> Convert all io slave .protocol data to json and embed it.
> Allows easier deployment of the slaves.
> 
> 
> Diffs
> -----
> 
>   src/ioslaves/http/CMakeLists.txt 76a8e28 
>   src/ioslaves/help/main_ghelp.cpp 59c8558 
>   src/ioslaves/help/main.cpp 9939196 
>   src/ioslaves/help/help.protocol 1deefe5 
>   src/ioslaves/help/help.json PRE-CREATION 
>   src/ioslaves/help/ghelp.protocol d2a642a 
>   src/ioslaves/help/ghelp.json PRE-CREATION 
>   src/ioslaves/help/CMakeLists.txt 867b59d 
>   src/ioslaves/ftp/ftp.protocol 4c5f80c 
>   src/ioslaves/ftp/ftp.json PRE-CREATION 
>   src/ioslaves/ftp/ftp.cpp 382723a 
>   src/ioslaves/ftp/CMakeLists.txt 04f5600 
>   src/ioslaves/file/file.protocol 523c0f5 
>   src/ioslaves/file/file.json PRE-CREATION 
>   src/ioslaves/file/file.cpp 5ef1587 
>   src/ioslaves/file/CMakeLists.txt cb85cfb 
>   autotests/kprotocolinfotest.cpp fa3ad38 
>   src/ioslaves/http/http.protocol 49e5dc5 
>   src/ioslaves/http/https.protocol c15d06f 
>   src/ioslaves/http/webdav.protocol 05c977a 
>   src/ioslaves/http/webdavs.protocol d5e4b2f 
>   src/ioslaves/trash/CMakeLists.txt 05161cd 
>   src/ioslaves/trash/kio_trash.cpp cb23169 
>   src/ioslaves/trash/trash.json PRE-CREATION 
>   src/ioslaves/trash/trash.protocol 7430575 
> 
> Diff: https://git.reviewboard.kde.org/r/125869/diff/
> 
> 
> Testing
> -------
> 
> Tests still work (one needed patching, as the exec line contains now the full path).
> 
> Correction: Somehow the ./autotests/jobtest test is unstable for me here, sometimes it works, sometimes not :/ but even without this change.
> 
> 
> Thanks,
> 
> Christoph Cullmann
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20151030/35550eea/attachment-0001.html>