<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/125869/">https://git.reviewboard.kde.org/r/125869/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On October 30th, 2015, 7:29 a.m. UTC, <b>David Faure</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="https://git.reviewboard.kde.org/r/125869/diff/1/?file=413338#file413338line6" style="color: black; font-weight: bold; text-decoration: underline;">src/ioslaves/trash/trash.json</a>
<span style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2"></font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
<th bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">6</font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="s2">"Ursprünglicher Pfad"</span><span class="p">,</span></pre></td>
</tr>
</tbody>
</table>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">That doesn't look very English to me ;)</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">The original is:</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">ExtraNames=Original Path,Deletion Date</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">But this shows a problem: missing support for translating this field. We didn't realize there was a translatable field in these files. Please add support for translations, like was done for other json files (talk to e.g. Luigi Toscano).</p></pre>
</blockquote>
<p>On October 30th, 2015, 7:43 a.m. UTC, <b>Christoph Cullmann</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Hmm, then we have a problem: We can no longer convert the stuff and remove the .protocol files, or?</p></pre>
</blockquote>
<p>On October 30th, 2015, 8:23 a.m. UTC, <b>Christoph Cullmann</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Ok, did read up a bit, ExtraNames seems to be the only translated thing (at least if I read KProtocolInfo docs the right way).
Can do the same trick as desktop2json does for that. Seems not that hard.
But then we need CMake stuff for it, or? To convert on the fly to have translations using the .protocol files like we have ATM in the .desktop files for the plugin stuff.</p></pre>
</blockquote>
</blockquote>
<pre style="margin-left: 1em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">I don't think you're looking in the right direction. AFAIK there is support for translating json files directly in l10n (json -> po -> json) these days. As I said, please ask Luigi or maybe Albert.</p></pre>
<br />
<p>- David</p>
<br />
<p>On October 29th, 2015, 5:03 p.m. UTC, Christoph Cullmann wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: 1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
<div>Review request for KDE Frameworks, Alex Richardson and David Faure.</div>
<div>By Christoph Cullmann.</div>
<p style="color: grey;"><i>Updated Oct. 29, 2015, 5:03 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
kio
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Convert all io slave .protocol data to json and embed it.
Allows easier deployment of the slaves.</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Tests still work (one needed patching, as the exec line contains now the full path).</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Correction: Somehow the ./autotests/jobtest test is unstable for me here, sometimes it works, sometimes not :/ but even without this change.</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>src/ioslaves/http/CMakeLists.txt <span style="color: grey">(76a8e28)</span></li>
<li>src/ioslaves/help/main_ghelp.cpp <span style="color: grey">(59c8558)</span></li>
<li>src/ioslaves/help/main.cpp <span style="color: grey">(9939196)</span></li>
<li>src/ioslaves/help/help.protocol <span style="color: grey">(1deefe5)</span></li>
<li>src/ioslaves/help/help.json <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/ioslaves/help/ghelp.protocol <span style="color: grey">(d2a642a)</span></li>
<li>src/ioslaves/help/ghelp.json <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/ioslaves/help/CMakeLists.txt <span style="color: grey">(867b59d)</span></li>
<li>src/ioslaves/ftp/ftp.protocol <span style="color: grey">(4c5f80c)</span></li>
<li>src/ioslaves/ftp/ftp.json <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/ioslaves/ftp/ftp.cpp <span style="color: grey">(382723a)</span></li>
<li>src/ioslaves/ftp/CMakeLists.txt <span style="color: grey">(04f5600)</span></li>
<li>src/ioslaves/file/file.protocol <span style="color: grey">(523c0f5)</span></li>
<li>src/ioslaves/file/file.json <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/ioslaves/file/file.cpp <span style="color: grey">(5ef1587)</span></li>
<li>src/ioslaves/file/CMakeLists.txt <span style="color: grey">(cb85cfb)</span></li>
<li>autotests/kprotocolinfotest.cpp <span style="color: grey">(fa3ad38)</span></li>
<li>src/ioslaves/http/http.protocol <span style="color: grey">(49e5dc5)</span></li>
<li>src/ioslaves/http/https.protocol <span style="color: grey">(c15d06f)</span></li>
<li>src/ioslaves/http/webdav.protocol <span style="color: grey">(05c977a)</span></li>
<li>src/ioslaves/http/webdavs.protocol <span style="color: grey">(d5e4b2f)</span></li>
<li>src/ioslaves/trash/CMakeLists.txt <span style="color: grey">(05161cd)</span></li>
<li>src/ioslaves/trash/kio_trash.cpp <span style="color: grey">(cb23169)</span></li>
<li>src/ioslaves/trash/trash.json <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/ioslaves/trash/trash.protocol <span style="color: grey">(7430575)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/125869/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>