Review Request 125449: Add support for desktop file name to KAboutData

[Martin Gräßlin]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125449/
-----------------------------------------------------------

(Updated Oct. 30, 2015, 8:01 a.m.)


Status
------

This change has been marked as submitted.


Review request for KDE Frameworks, David Faure and Marco Martin.


Changes
-------

Submitted with commit c0313039170d751c61a44a8f97e199b7ed8ffa4f by Martin Gräßlin to branch master.


Repository: kcoreaddons


Description
-------

This change introduces a way to set the new QGuiApplication property
"desktopFileName" through KAboutData. By default it gets constructed
to a combination of reverse domain name and component name.
E.g.: org.kde.kwrite

In addition a new command line option --desktopfile is added to allow
passing the desktop file name to the application. This is in particular
useful for wrapper applications (such as kpackagelauncherqml) and
applications having in general multiple desktop files. Thus each desktop
file can put it's own name into the exec command.


Diffs
-----

  autotests/kaboutdatatest.cpp 08690b7abed7727ab5610e41cfb124fc27cd88a5 
  src/lib/kaboutdata.h 134819b1ee32d5cf1e4f379b547e52e387dd674e 
  src/lib/kaboutdata.cpp af10fc60053b294789f2813680299be2bc4b7a64 

Diff: https://git.reviewboard.kde.org/r/125449/diff/


Testing
-------

See added unit test. For the command line parser I only tested whether it gets added to applications.


Thanks,

Martin Gräßlin

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20151030/63377469/attachment.html>