Review Request 125449: Add support for desktop file name to KAboutData

[David Faure]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125449/#review87182
-----------------------------------------------------------

Ship it!


ah sorry I skipped that one when I saw it was already approved... but yeah actually I found a few things to say ;)


src/lib/kaboutdata.h (line 916)
<https://git.reviewboard.kde.org/r/125449/#comment59899>

    ... and without extension, right?



src/lib/kaboutdata.h (line 934)
<https://git.reviewboard.kde.org/r/125449/#comment59901>

    5.16 now



src/lib/kaboutdata.h (line 939)
<https://git.reviewboard.kde.org/r/125449/#comment59900>

    Give an example, or do say exactly that this is only the base name, no path and no extension.


- David Faure


On Sept. 29, 2015, 11:53 a.m., Martin Gräßlin wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/125449/
> -----------------------------------------------------------
> 
> (Updated Sept. 29, 2015, 11:53 a.m.)
> 
> 
> Review request for KDE Frameworks, David Faure and Marco Martin.
> 
> 
> Repository: kcoreaddons
> 
> 
> Description
> -------
> 
> This change introduces a way to set the new QGuiApplication property
> "desktopFileName" through KAboutData. By default it gets constructed
> to a combination of reverse domain name and component name.
> E.g.: org.kde.kwrite
> 
> In addition a new command line option --desktopfile is added to allow
> passing the desktop file name to the application. This is in particular
> useful for wrapper applications (such as kpackagelauncherqml) and
> applications having in general multiple desktop files. Thus each desktop
> file can put it's own name into the exec command.
> 
> 
> Diffs
> -----
> 
>   autotests/kaboutdatatest.cpp 08690b7abed7727ab5610e41cfb124fc27cd88a5 
>   src/lib/kaboutdata.h 134819b1ee32d5cf1e4f379b547e52e387dd674e 
>   src/lib/kaboutdata.cpp af10fc60053b294789f2813680299be2bc4b7a64 
> 
> Diff: https://git.reviewboard.kde.org/r/125449/diff/
> 
> 
> Testing
> -------
> 
> See added unit test. For the command line parser I only tested whether it gets added to applications.
> 
> 
> Thanks,
> 
> Martin Gräßlin
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20151021/1286a36f/attachment.html>