Review Request 125874: make kio_http_cache_cleaner deployable in application installer/bundles
Christoph Cullmann
cullmann at kde.org
Thu Oct 29 21:37:11 UTC 2015
> On Oct. 29, 2015, 6:40 p.m., Kevin Funk wrote:
> > LGTM.
> >
> > Let me just say: Great work Christoph! Glad to see somebody working on these issues.
Thanks :)
Just tested on the Mac again (bah, slow compile), with that and the other patch for embedding all .protocols in the slaves, KWrite is fine to load e.g. http://www.kde.org as file and download updated highlighting definitions without any patches to Qt nor deploying any kio files beside the libs + plugins + kioslave/kio_http_cache_cleaner helper executables.
The only remaining error seen is:
Can't communicate with kded_kcookiejar!
- Christoph
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125874/#review87690
-----------------------------------------------------------
On Oct. 29, 2015, 5:21 p.m., Christoph Cullmann wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/125874/
> -----------------------------------------------------------
>
> (Updated Oct. 29, 2015, 5:21 p.m.)
>
>
> Review request for KDE Frameworks and David Faure.
>
>
> Repository: kio
>
>
> Description
> -------
>
> make kio_http_cache_cleaner deployable in application installer/bundles
>
> uses findExecutable, that fixes problem with .exe extension on Windows, too.
>
>
> Diffs
> -----
>
> src/ioslaves/http/http.cpp 2ff7ee5
>
> Diff: https://git.reviewboard.kde.org/r/125874/diff/
>
>
> Testing
> -------
>
> Still gets found.
>
>
> Thanks,
>
> Christoph Cullmann
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20151029/eb34f689/attachment.html>
More information about the Kde-frameworks-devel
mailing list