Review Request 125874: make kio_http_cache_cleaner deployable in application installer/bundles
Kevin Funk
kfunk at kde.org
Thu Oct 29 18:40:03 UTC 2015
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125874/#review87690
-----------------------------------------------------------
LGTM.
Let me just say: Great work Christoph! Glad to see somebody working on these issues.
- Kevin Funk
On Oct. 29, 2015, 5:21 p.m., Christoph Cullmann wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/125874/
> -----------------------------------------------------------
>
> (Updated Oct. 29, 2015, 5:21 p.m.)
>
>
> Review request for KDE Frameworks and David Faure.
>
>
> Repository: kio
>
>
> Description
> -------
>
> make kio_http_cache_cleaner deployable in application installer/bundles
>
> uses findExecutable, that fixes problem with .exe extension on Windows, too.
>
>
> Diffs
> -----
>
> src/ioslaves/http/http.cpp 2ff7ee5
>
> Diff: https://git.reviewboard.kde.org/r/125874/diff/
>
>
> Testing
> -------
>
> Still gets found.
>
>
> Thanks,
>
> Christoph Cullmann
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20151029/eeca87ed/attachment.html>
More information about the Kde-frameworks-devel
mailing list