Review Request 125859: Wait for async call starting helper to finish before checking the reply

David Edmundson david at davidedmundson.co.uk
Thu Oct 29 14:22:48 UTC 2015


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125859/
-----------------------------------------------------------

(Updated Oct. 29, 2015, 2:22 p.m.)


Status
------

This change has been marked as submitted.


Review request for KDE Frameworks and Martin Gräßlin.


Changes
-------

Submitted with commit 335ad976ac9f11cd51a838a7ae7dcb38d948bfcf by David Edmundson to branch master.


Repository: kauth


Description
-------

Otherwise the check is effectively useless.

This meant in the case where the helper could not be started the job
would never finish and clients would stuck idle or blocked.

BUG: 344473
BUG: 300951
BUG: 345234


Diffs
-----

  src/backends/dbus/DBusHelperProxy.cpp 8cf38a0252408d14cda744a7e6cdc9c60a0c3b29 

Diff: https://git.reviewboard.kde.org/r/125859/diff/


Testing
-------


Thanks,

David Edmundson

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20151029/e253e160/attachment.html>


More information about the Kde-frameworks-devel mailing list