Review Request 125859: Wait for async call starting helper to finish before checking the reply

[Martin Gräßlin]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125859/#review87669
-----------------------------------------------------------

Ship it!


looks correct to me. Nice spot!

- Martin Gräßlin


On Oct. 29, 2015, 2:56 p.m., David Edmundson wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/125859/
> -----------------------------------------------------------
> 
> (Updated Oct. 29, 2015, 2:56 p.m.)
> 
> 
> Review request for KDE Frameworks and Martin Gräßlin.
> 
> 
> Repository: kauth
> 
> 
> Description
> -------
> 
> Otherwise the check is effectively useless.
> 
> This meant in the case where the helper could not be started the job
> would never finish and clients would stuck idle or blocked.
> 
> BUG: 344473
> BUG: 300951
> BUG: 345234
> 
> 
> Diffs
> -----
> 
>   src/backends/dbus/DBusHelperProxy.cpp 8cf38a0252408d14cda744a7e6cdc9c60a0c3b29 
> 
> Diff: https://git.reviewboard.kde.org/r/125859/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> David Edmundson
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20151029/8ce82a12/attachment-0001.html>