Review Request 125803: KBuildSycoca: always save, even if no change in .desktop file was noticed.

[David Faure]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125803/
-----------------------------------------------------------

(Updated Oct. 27, 2015, 7:40 a.m.)


Status
------

This change has been marked as submitted.


Review request for KDE Frameworks and Albert Astals Cid.


Changes
-------

Submitted with commit 0f816ab3fada9f57e836da78470003dd24d26a27 by David Faure to branch master.


Repository: kservice


Description
-------

This fixes the case where a directory is "touched", so when KSycoca
compares directory timestamps it decides to rebuild, but then KBuildSycoca
doesn't find any real change and doesn't save. This can then happen
all over again at the next timestamp check.

CCBUG: 353203


Diffs
-----

  autotests/ksycocatest.cpp f0df0b2a0fa4cb8e1bbba641db99e576a0399b4b 
  src/sycoca/kbuildsycoca.cpp 1deae14b8546d87b2f8d94510ae0d7077f377fb0 
  src/sycoca/ksycoca.cpp a692bc87ca1ca4bc1885e9ace3454470a0205ac4 

Diff: https://git.reviewboard.kde.org/r/125803/diff/


Testing
-------

ksycocatest was failing on CI, I changed XDG_CONFIG_DIRS in the unittest and then I could replicate the problem.
ksycocatest passes again with this fix.


Thanks,

David Faure

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20151027/6496f09d/attachment.html>