Review Request 125803: KBuildSycoca: always save, even if no change in .desktop file was noticed.

[Albert Astals Cid]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125803/#review87455
-----------------------------------------------------------

Ship it!


Ship It!

- Albert Astals Cid


On oct. 26, 2015, 8:05 a.m., David Faure wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/125803/
> -----------------------------------------------------------
> 
> (Updated oct. 26, 2015, 8:05 a.m.)
> 
> 
> Review request for KDE Frameworks and Albert Astals Cid.
> 
> 
> Repository: kservice
> 
> 
> Description
> -------
> 
> This fixes the case where a directory is "touched", so when KSycoca
> compares directory timestamps it decides to rebuild, but then KBuildSycoca
> doesn't find any real change and doesn't save. This can then happen
> all over again at the next timestamp check.
> 
> CCBUG: 353203
> 
> 
> Diffs
> -----
> 
>   autotests/ksycocatest.cpp f0df0b2a0fa4cb8e1bbba641db99e576a0399b4b 
>   src/sycoca/kbuildsycoca.cpp 1deae14b8546d87b2f8d94510ae0d7077f377fb0 
>   src/sycoca/ksycoca.cpp a692bc87ca1ca4bc1885e9ace3454470a0205ac4 
> 
> Diff: https://git.reviewboard.kde.org/r/125803/diff/
> 
> 
> Testing
> -------
> 
> ksycocatest was failing on CI, I changed XDG_CONFIG_DIRS in the unittest and then I could replicate the problem.
> ksycocatest passes again with this fix.
> 
> 
> Thanks,
> 
> David Faure
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20151026/51b2f614/attachment-0001.html>