Review Request 125809: Fix logic (and warnings) in ModelContextMenu.qml

Aleix Pol Gonzalez aleixpol at kde.org
Mon Oct 26 17:22:19 UTC 2015


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125809/
-----------------------------------------------------------

(Updated Oct. 26, 2015, 5:22 p.m.)


Status
------

This change has been marked as submitted.


Review request for KDE Frameworks and Plasma.


Changes
-------

Submitted with commit 36288df5ac48901134ca98ff8131d87ad434e2a1 by Aleix Pol to branch master.


Repository: plasma-framework


Description
-------

It was checking that a variable existed, then it used it. Now it works like the rest of the properties.


Diffs
-----

  src/declarativeimports/plasmacomponents/qml/ModelContextMenu.qml f8fddb7 

Diff: https://git.reviewboard.kde.org/r/125809/diff/


Testing
-------

Booted again, tests still pass, no warnings.


Thanks,

Aleix Pol Gonzalez

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20151026/eb4fafa4/attachment-0001.html>


More information about the Kde-frameworks-devel mailing list