Review Request 125809: Fix logic (and warnings) in ModelContextMenu.qml

David Edmundson david at davidedmundson.co.uk
Mon Oct 26 17:16:01 UTC 2015


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125809/#review87441
-----------------------------------------------------------

Ship it!


Ship It!

- David Edmundson


On Oct. 26, 2015, 4:07 p.m., Aleix Pol Gonzalez wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/125809/
> -----------------------------------------------------------
> 
> (Updated Oct. 26, 2015, 4:07 p.m.)
> 
> 
> Review request for KDE Frameworks and Plasma.
> 
> 
> Repository: plasma-framework
> 
> 
> Description
> -------
> 
> It was checking that a variable existed, then it used it. Now it works like the rest of the properties.
> 
> 
> Diffs
> -----
> 
>   src/declarativeimports/plasmacomponents/qml/ModelContextMenu.qml f8fddb7 
> 
> Diff: https://git.reviewboard.kde.org/r/125809/diff/
> 
> 
> Testing
> -------
> 
> Booted again, tests still pass, no warnings.
> 
> 
> Thanks,
> 
> Aleix Pol Gonzalez
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20151026/83aee0d4/attachment.html>


More information about the Kde-frameworks-devel mailing list