Review Request 125806: Fix build with -DDEFINE_NO_DEPRECATED=1

Boudewijn Rempt boud at valdyas.org
Mon Oct 26 16:58:10 UTC 2015


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125806/
-----------------------------------------------------------

(Updated Oct. 26, 2015, 4:58 p.m.)


Status
------

This change has been marked as submitted.


Review request for KDE Frameworks and Christoph Feck.


Changes
-------

Submitted with commit 7d8b8417cbb6b8439b6689963758e2c20b091fac by Boudewijn Rempt to branch master.


Repository: kwidgetsaddons


Description
-------

With no-deprecated set, clang refuses to build kmultitabbar:

/Users/boudewijnrempt/kf5/b/ext_frameworks/ext_kwidgetsaddons-prefix/src/ext_kwidgetsaddons/src/kmultitabbar.cpp:564:19: error: out-of-line definition of 'appendButton' does not match any
      declaration in 'KMultiTabBar'
int KMultiTabBar::appendButton(const QPixmap &pic, int id, QMenu *popup, const QString &x)
                  ^~~~~~~~~~~~
/Users/boudewijnrempt/kf5/b/ext_frameworks/ext_kwidgetsaddons-prefix/src/ext_kwidgetsaddons/src/kmultitabbar.cpp:593:19: error: out-of-line definition of 'appendTab' does not match any
      declaration in 'KMultiTabBar'
int KMultiTabBar::appendTab(const QPixmap &pic, int id, const QString &text)
                  ^~~~~~~~~


Diffs
-----

  src/kmultitabbar.cpp 2327748 

Diff: https://git.reviewboard.kde.org/r/125806/diff/


Testing
-------


Thanks,

Boudewijn Rempt

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20151026/a951171c/attachment.html>


More information about the Kde-frameworks-devel mailing list