Review Request 125806: Fix build with -DDEFINE_NO_DEPRECATED=1

Christoph Feck cfeck at kde.org
Mon Oct 26 10:19:12 UTC 2015


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125806/#review87415
-----------------------------------------------------------

Ship it!



src/kmultitabbar.cpp (line 601)
<https://git.reviewboard.kde.org/r/125806/#comment60007>

    Add empty line after #endif


- Christoph Feck


On Oct. 26, 2015, 9:35 a.m., Boudewijn Rempt wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/125806/
> -----------------------------------------------------------
> 
> (Updated Oct. 26, 2015, 9:35 a.m.)
> 
> 
> Review request for KDE Frameworks and Christoph Feck.
> 
> 
> Repository: kwidgetsaddons
> 
> 
> Description
> -------
> 
> With no-deprecated set, clang refuses to build kmultitabbar:
> 
> /Users/boudewijnrempt/kf5/b/ext_frameworks/ext_kwidgetsaddons-prefix/src/ext_kwidgetsaddons/src/kmultitabbar.cpp:564:19: error: out-of-line definition of 'appendButton' does not match any
>       declaration in 'KMultiTabBar'
> int KMultiTabBar::appendButton(const QPixmap &pic, int id, QMenu *popup, const QString &x)
>                   ^~~~~~~~~~~~
> /Users/boudewijnrempt/kf5/b/ext_frameworks/ext_kwidgetsaddons-prefix/src/ext_kwidgetsaddons/src/kmultitabbar.cpp:593:19: error: out-of-line definition of 'appendTab' does not match any
>       declaration in 'KMultiTabBar'
> int KMultiTabBar::appendTab(const QPixmap &pic, int id, const QString &text)
>                   ^~~~~~~~~
> 
> 
> Diffs
> -----
> 
>   src/kmultitabbar.cpp 2327748 
> 
> Diff: https://git.reviewboard.kde.org/r/125806/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Boudewijn Rempt
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20151026/a741c70d/attachment.html>


More information about the Kde-frameworks-devel mailing list