Question about goal of Windows/Mac frameworks

[Ralf Habacker]

Am 26.10.2015 um 10:33 schrieb Christoph Cullmann:
> Hi,
>
>>> Boudewijn Rempt <boud at valdyas.org> hat am 23. Oktober 2015 um 19:46 geschrieben:
>>> For Krita, we decided ages ago to simply open a browser on the userbase
>>> manual of Krita. Yes, it is conceivable that there are people who use
>>> Krita without internet access who still need help, it's just not very
>>> likely. About one complaint, maybe two in the past couple of years.
>> umbrello installer also uses a khelpcenter online replacement to access umbrello
>> documentation from the internet instead of a local installation (see
>> https://build.opensuse.org/package/show?project=windows%3Amingw%3Awin32&package=mingw32-khelpcenter-online)
>> Currently it is limited to umbrello, but could be easily extended. klauncher
>> and dbus is required to launch it from the help menu.
>> Ralf
> I would tend to just http://doc.qt.io/qt-5/qdesktopservices.html with the url to the offline copy or online page.
>
> No dbus nor klauncher nor extra bundled application needed.
> Perhaps that can be even done by magic in the frameworks ;=)
>From what I see from the frameworks source do KXMLGui based applications
call QDesktopServices:openURL already, see
*https://projects.kde.org/projects/frameworks/kxmlgui/repository/revisions/master/entry/src/khelpmenu.cpp#L249*.

In KGuiAddons there is a global instance of class UrlHandler, which setup setURLHandler() in https://projects.kde.org/projects/frameworks/kguiaddons/repository/revisions/master/entry/src/util/urlhandler.cpp.
Selecting "show manual" in KXMLGui based application will therefore be handled by this UrlHandler instance. In case the khelpcenter executable has not been found QDesktopServices::openUrl(u) is called again. Candidate for a recursive loop ?
 
BTW: You mentioned the url  https://docs.kde.org/stable5/en/applications/kate/index.html in an earlier email to access online help. khelpcenter determine the currently selected language by itself and loads the language related doc. This need to be fixed in class UrlHandler too.


Ralf 

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20151026/44fa6bb4/attachment.html>