Review Request 125772: Improve search for drkonqui and keep it silent per default if not found
David Faure
faure at kde.org
Sat Oct 24 18:04:50 UTC 2015
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125772/#review87344
-----------------------------------------------------------
Ship it!
Ship It!
- David Faure
On Oct. 24, 2015, 2:27 p.m., Christoph Cullmann wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/125772/
> -----------------------------------------------------------
>
> (Updated Oct. 24, 2015, 2:27 p.m.)
>
>
> Review request for KDE Frameworks and David Faure.
>
>
> Repository: kcrash
>
>
> Description
> -------
>
> Search not only in env var + install prefix but in application binary directory and libexec path as configured for qt (or qt.conf).
> That allows it to bundle drkonqui if wanted.
> Beside, make the output of "not found" an per default hidden debug message, as otherwise, any application using kcrash without workspace stuff installed warns on start.
> Sideeffect: decodeName used to decode the CMAKE var, like in other places in frameworks.
>
>
> Diffs
> -----
>
> src/kcrash.cpp a5dbeef
>
> Diff: https://git.reviewboard.kde.org/r/125772/diff/
>
>
> Testing
> -------
>
> make && make test
> tried out kwrite with it, got useful search paths
>
>
> Thanks,
>
> Christoph Cullmann
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20151024/b569f5a6/attachment.html>
More information about the Kde-frameworks-devel
mailing list