Review Request 125772: Improve search for drkonqui and keep it silent per default if not found

Christoph Cullmann cullmann at kde.org
Sat Oct 24 14:27:31 UTC 2015


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125772/
-----------------------------------------------------------

(Updated Oct. 24, 2015, 2:27 p.m.)


Review request for KDE Frameworks and David Faure.


Changes
-------

Uploaded diff with Info instead of Debug :/


Repository: kcrash


Description
-------

Search not only in env var + install prefix but in application binary directory and libexec path as configured for qt (or qt.conf).
That allows it to bundle drkonqui if wanted.
Beside, make the output of "not found" an per default hidden debug message, as otherwise, any application using kcrash without workspace stuff installed warns on start.
Sideeffect: decodeName used to decode the CMAKE var, like in other places in frameworks.


Diffs (updated)
-----

  src/kcrash.cpp a5dbeef 

Diff: https://git.reviewboard.kde.org/r/125772/diff/


Testing
-------

make && make test
tried out kwrite with it, got useful search paths


Thanks,

Christoph Cullmann

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20151024/3b34dfb4/attachment-0001.html>


More information about the Kde-frameworks-devel mailing list