Review Request 125750: Reduce some allocations

[Aleix Pol Gonzalez]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125750/
-----------------------------------------------------------

(Updated Oct. 22, 2015, 1:20 p.m.)


Status
------

This change has been marked as submitted.


Review request for KDE Frameworks and Sebastian Kügler.


Changes
-------

Submitted with commit 32e48f1911103537645c77d50ea3ddc192b0befe by Aleix Pol to branch master.


Repository: kcoreaddons


Description
-------

I know this could be done so much better and there's a comment saying it's transitional (heh), but this happens to be called a ton of times on every plasma boot through [1].
Actually, why is it transitional? Are we supposed to move from metadata.desktop to metadata.json? Or is it because we should all be using `kpackagetool5 --generate-index`?

[1] KPluginMetaData::loadFromDesktopFile(QString const&, QStringList const&)


Diffs
-----

  src/lib/plugin/desktopfileparser.cpp 7a4556a 

Diff: https://git.reviewboard.kde.org/r/125750/diff/


Testing
-------

Tests pass, plasma still boots.


Thanks,

Aleix Pol Gonzalez

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20151022/d5155141/attachment.html>