Review Request 125750: Reduce some allocations

[Sebastian Kügler]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125750/#review87237
-----------------------------------------------------------

Ship it!


Ship It!

- Sebastian Kügler


On Oct. 22, 2015, 2:05 a.m., Aleix Pol Gonzalez wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/125750/
> -----------------------------------------------------------
> 
> (Updated Oct. 22, 2015, 2:05 a.m.)
> 
> 
> Review request for KDE Frameworks and Sebastian Kügler.
> 
> 
> Repository: kcoreaddons
> 
> 
> Description
> -------
> 
> I know this could be done so much better and there's a comment saying it's transitional (heh), but this happens to be called a ton of times on every plasma boot through [1].
> Actually, why is it transitional? Are we supposed to move from metadata.desktop to metadata.json? Or is it because we should all be using `kpackagetool5 --generate-index`?
> 
> [1] KPluginMetaData::loadFromDesktopFile(QString const&, QStringList const&)
> 
> 
> Diffs
> -----
> 
>   src/lib/plugin/desktopfileparser.cpp 7a4556a 
> 
> Diff: https://git.reviewboard.kde.org/r/125750/diff/
> 
> 
> Testing
> -------
> 
> Tests pass, plasma still boots.
> 
> 
> Thanks,
> 
> Aleix Pol Gonzalez
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20151022/b60321ff/attachment.html>