Review Request 125695: Make KAboutData::translators/setTranslators simple

Michael Pyne mpyne at kde.org
Tue Oct 20 02:03:26 UTC 2015


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125695/#review87106
-----------------------------------------------------------

Ship it!


I concur.

- Michael Pyne


On Oct. 18, 2015, 10:38 p.m., Albert Astals Cid wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/125695/
> -----------------------------------------------------------
> 
> (Updated Oct. 18, 2015, 10:38 p.m.)
> 
> 
> Review request for KDE Frameworks, Chusslove Illich and Michael Pyne.
> 
> 
> Repository: kcoreaddons
> 
> 
> Description
> -------
> 
> Move the responsability to the user.
> 
> Document how to implement them either using ki18n and document that KMainWindow does it for you.
> 
> 
> Diffs
> -----
> 
>   src/lib/kaboutdata.h a94e2c5 
>   src/lib/kaboutdata.cpp af10fc6 
> 
> Diff: https://git.reviewboard.kde.org/r/125695/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Albert Astals Cid
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20151020/2fda83dc/attachment.html>


More information about the Kde-frameworks-devel mailing list