Review Request 125695: Make KAboutData::translators/setTranslators simple

[Chusslove Illich]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125695/#review87086
-----------------------------------------------------------

Ship it!


Technically I see no other solution. Because tier 1, it should not depend on anything Gettext related. And because there is no such special message convention in Qt, makes little sense to use Qt::tr().

- Chusslove Illich


On Окт. 19, 2015, 12:38 пре п., Albert Astals Cid wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/125695/
> -----------------------------------------------------------
> 
> (Updated Окт. 19, 2015, 12:38 пре п.)
> 
> 
> Review request for KDE Frameworks, Chusslove Illich and Michael Pyne.
> 
> 
> Repository: kcoreaddons
> 
> 
> Description
> -------
> 
> Move the responsability to the user.
> 
> Document how to implement them either using ki18n and document that KMainWindow does it for you.
> 
> 
> Diffs
> -----
> 
>   src/lib/kaboutdata.h a94e2c5 
>   src/lib/kaboutdata.cpp af10fc6 
> 
> Diff: https://git.reviewboard.kde.org/r/125695/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Albert Astals Cid
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20151019/1a439ecb/attachment.html>