Review Request 125647: Fix KArchiveTest::testTarCopyTo on NTFS

[Eric Lemanissier]

> On oct. 15, 2015, 2:36 après-midi, Aleix Pol Gonzalez wrote:
> > Maybe such code should go in QFileInfo::permissions, no?

Well, as stated in the documentation "On NTFS file systems, ownership and permissions checking is disabled by default for performance reasons", so I guess it won't change.


- Eric


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125647/#review86886
-----------------------------------------------------------


On oct. 15, 2015, 2:29 après-midi, Eric Lemanissier wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/125647/
> -----------------------------------------------------------
> 
> (Updated oct. 15, 2015, 2:29 après-midi)
> 
> 
> Review request for KDE Frameworks.
> 
> 
> Repository: karchive
> 
> 
> Description
> -------
> 
> KArchiveTest::testTarCopyTo fails on NTFS, because qt_ntfs_permission_lookup variable is not updated before checking file permissions (http://doc.qt.io/qt-5/qfileinfo.html#ntfs-permissions)
> 
> 
> Diffs
> -----
> 
>   autotests/karchivetest.cpp b1d5555 
> 
> Diff: https://git.reviewboard.kde.org/r/125647/diff/
> 
> 
> Testing
> -------
> 
> Compiled and ran test successfully
> 
> 
> Thanks,
> 
> Eric Lemanissier
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20151015/8c536a9b/attachment.html>