Review Request 125647: Fix KArchiveTest::testTarCopyTo on NTFS
Aleix Pol Gonzalez
aleixpol at kde.org
Thu Oct 15 14:36:32 UTC 2015
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125647/#review86886
-----------------------------------------------------------
Maybe such code should go in QFileInfo::permissions, no?
- Aleix Pol Gonzalez
On Oct. 15, 2015, 4:29 p.m., Eric Lemanissier wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/125647/
> -----------------------------------------------------------
>
> (Updated Oct. 15, 2015, 4:29 p.m.)
>
>
> Review request for KDE Frameworks.
>
>
> Repository: karchive
>
>
> Description
> -------
>
> KArchiveTest::testTarCopyTo fails on NTFS, because qt_ntfs_permission_lookup variable is not updated before checking file permissions (http://doc.qt.io/qt-5/qfileinfo.html#ntfs-permissions)
>
>
> Diffs
> -----
>
> autotests/karchivetest.cpp b1d5555
>
> Diff: https://git.reviewboard.kde.org/r/125647/diff/
>
>
> Testing
> -------
>
> Compiled and ran test successfully
>
>
> Thanks,
>
> Eric Lemanissier
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20151015/333594db/attachment.html>
More information about the Kde-frameworks-devel
mailing list