Review Request 125532: KTextEdit: fix loading Sonnet default settings, add context menu to switch spell-checking language

Daniel Vrátil dvratil at kde.org
Mon Oct 12 12:32:39 UTC 2015


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125532/
-----------------------------------------------------------

(Updated Oct. 12, 2015, 12:32 p.m.)


Status
------

This change has been marked as submitted.


Review request for KDE Frameworks and Laurent Montel.


Changes
-------

Submitted with commit 558f82041f2f5eff92109a5412b6fe81d1c5d89e by Dan Vrátil to branch master.


Repository: ktextwidgets


Description
-------

This patch makes KTextEdit read the default Sonnet settings from the new location that Sonnet uses (~/.config/KDE/Sonnet.conf instead of ~/.config/sonnetrc) - IMO there should be a better API to find out the default value, because having to construct Sonnet::Highlighter just to find out Sonnet is off by default  feels a bit clumsy :) (but that's offtopic for this RR).

Additionally this patch adds a new submenu to the editor's context menu that allows to switch between language used for spellchecking.

The submenu code comes from PimCommon::CustomTextEditor in kdepim.git.

I will commit as two separate commits.


Diffs
-----

  src/widgets/ktextedit.cpp f549825 

Diff: https://git.reviewboard.kde.org/r/125532/diff/


Testing
-------

Switched KNoteEditor in KNotes in KDE PIM (which uses PimCommon::CustomTextEditor) to use this patched KTextEdit, everything works as before.


Thanks,

Daniel Vrátil

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20151012/994fa1e8/attachment.html>


More information about the Kde-frameworks-devel mailing list