Review Request 125532: KTextEdit: fix loading Sonnet default settings, add context menu to switch spell-checking language

[David Faure]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125532/#review86613
-----------------------------------------------------------

Ship it!



src/widgets/ktextedit.cpp (line 83)
<https://git.reviewboard.kde.org/r/125532/#comment59619>

    [unrelated to this patch, but this should really be renamed spellCheckingEnabled]



src/widgets/ktextedit.cpp (line 580)
<https://git.reviewboard.kde.org/r/125532/#comment59620>

    I would move the call to defaultLanguage() out of the loop, even though it's just 2 method calls every time.


- David Faure


On Oct. 5, 2015, 3:40 p.m., Daniel Vrátil wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/125532/
> -----------------------------------------------------------
> 
> (Updated Oct. 5, 2015, 3:40 p.m.)
> 
> 
> Review request for KDE Frameworks and Laurent Montel.
> 
> 
> Repository: ktextwidgets
> 
> 
> Description
> -------
> 
> This patch makes KTextEdit read the default Sonnet settings from the new location that Sonnet uses (~/.config/KDE/Sonnet.conf instead of ~/.config/sonnetrc) - IMO there should be a better API to find out the default value, because having to construct Sonnet::Highlighter just to find out Sonnet is off by default  feels a bit clumsy :) (but that's offtopic for this RR).
> 
> Additionally this patch adds a new submenu to the editor's context menu that allows to switch between language used for spellchecking.
> 
> The submenu code comes from PimCommon::CustomTextEditor in kdepim.git.
> 
> I will commit as two separate commits.
> 
> 
> Diffs
> -----
> 
>   src/widgets/ktextedit.cpp f549825 
> 
> Diff: https://git.reviewboard.kde.org/r/125532/diff/
> 
> 
> Testing
> -------
> 
> Switched KNoteEditor in KNotes in KDE PIM (which uses PimCommon::CustomTextEditor) to use this patched KTextEdit, everything works as before.
> 
> 
> Thanks,
> 
> Daniel Vrátil
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20151010/83340a6f/attachment.html>