Review Request 125531: Mark KProcess::pid() as depreciated

[David Edmundson]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125531/#review86448
-----------------------------------------------------------



src/lib/io/kprocess.h (line 320)
<https://git.reviewboard.kde.org/r/125531/#comment59564>

    I don't get this comment non unix comment.
    
    This ::pid() override does exactly what QProcess::processId() does
    
    qint64 QProcess::processId() const
    {
        Q_D(const QProcess);
    #ifdef Q_OS_WIN
        return d->pid ? d->pid->dwProcessId : 0;
    #else
        return d->pid;
    #endif
    }
    
    So it is a 1-1 drop in replacement


- David Edmundson


On Oct. 5, 2015, 3:31 p.m., Kurt Hindenburg wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/125531/
> -----------------------------------------------------------
> 
> (Updated Oct. 5, 2015, 3:31 p.m.)
> 
> 
> Review request for KDE Frameworks.
> 
> 
> Repository: kcoreaddons
> 
> 
> Description
> -------
> 
> QProcess::pid() has been depreciated since Qt5.3 - the replacement QProcess::processId() is not a drop-in replacement on non-UNIX systems.
> 
> I'm not positive this is the correct way of doing this.
> 
> http://doc.qt.io/qt-5/qprocess.html#processId
> http://doc.qt.io/qt-5/qprocess-obsolete.html#pid
> 
> 
> Diffs
> -----
> 
>   src/lib/io/kprocess.h d57061c 
>   src/lib/io/kprocess.cpp 1df61c0 
> 
> Diff: https://git.reviewboard.kde.org/r/125531/diff/
> 
> 
> Testing
> -------
> 
> tests pass
> 
> 
> Thanks,
> 
> Kurt Hindenburg
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20151007/649ff7b2/attachment.html>