Review Request 125531: Mark KProcess::pid() as depreciated
Kurt Hindenburg
kurt.hindenburg at gmail.com
Mon Oct 5 15:31:54 UTC 2015
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125531/
-----------------------------------------------------------
Review request for KDE Frameworks.
Repository: kcoreaddons
Description
-------
QProcess::pid() has been depreciated since Qt5.3 - the replacement QProcess::processId() is not a drop-in replacement on non-UNIX systems.
I'm not positive this is the correct way of doing this.
http://doc.qt.io/qt-5/qprocess.html#processId
http://doc.qt.io/qt-5/qprocess-obsolete.html#pid
Diffs
-----
src/lib/io/kprocess.h d57061c
src/lib/io/kprocess.cpp 1df61c0
Diff: https://git.reviewboard.kde.org/r/125531/diff/
Testing
-------
tests pass
Thanks,
Kurt Hindenburg
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20151005/83e7b3bb/attachment.html>
More information about the Kde-frameworks-devel
mailing list