Review Request 126039: When configfile is loaded from resource, do not issue file not found error

[Christoph Cullmann]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126039/#review88923
-----------------------------------------------------------


Ok for me, if that allows better error handling.

- Christoph Cullmann


On Nov. 12, 2015, 11:15 p.m., Andrew McCann wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126039/
> -----------------------------------------------------------
> 
> (Updated Nov. 12, 2015, 11:15 p.m.)
> 
> 
> Review request for KDE Frameworks, Christoph Cullmann and Jeremy Whiting.
> 
> 
> Repository: knewstuff
> 
> 
> Description
> -------
> 
> When configfile is loaded from resource, do not issue file not found error.
> 
> Encountered this problem while attempting to make KDevelop work on OSX as an app bundle.
> 
> Concretely, the logic error here is that the file actually is loaded and is aborting early. 
> 
> If the file were actually not found, the following code block that tests for validity will error anyway.
> 
> 
> Diffs
> -----
> 
>   src/core/engine.cpp 56912ddfa8312ea6233aecffda296f041b180237 
> 
> Diff: https://git.reviewboard.kde.org/r/126039/diff/
> 
> 
> Testing
> -------
> 
> Verify that loading configfile from qt5's resource system ex ":/kconfig/test.knsrc" now works and didn't before.
> 
> 
> Thanks,
> 
> Andrew McCann
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20151129/c9775940/attachment.html>