Review Request 126039: When configfile is loaded from resource, do not issue file not found error

Andrew McCann amccann at gmail.com
Thu Nov 12 03:35:17 UTC 2015


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126039/
-----------------------------------------------------------

Review request for KDE Frameworks and Jeremy Whiting.


Repository: knewstuff


Description
-------

When configfile is loaded from resource, do not issue file not found error.

Encountered this problem while attempting to make KDevelop work on OSX as an app bundle.

Concretely, the logic error here is that the file actually is loaded and is aborting early. 

If the file were actually not found, the following code block that tests for validity will error anyway.


Diffs
-----

  src/core/engine.cpp 56912ddfa8312ea6233aecffda296f041b180237 

Diff: https://git.reviewboard.kde.org/r/126039/diff/


Testing
-------

Verify that loading configfile from qt5's resource system ex ":/kconfig/test.knsrc" now works and didn't before.


Thanks,

Andrew McCann

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20151112/ac7ef8c2/attachment.html>


More information about the Kde-frameworks-devel mailing list