Review Request 125941: Add KCompressionDevice tests to KArchive

Romário Rios luizromario at gmail.com
Wed Nov 25 21:16:24 UTC 2015


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125941/
-----------------------------------------------------------

(Updated Nov. 25, 2015, 9:16 p.m.)


Review request for KDE Frameworks, Aleix Pol Gonzalez and David Faure.


Changes
-------

Make Qt5Network optional


Repository: karchive


Description
-------

I recently noticed that using KTar with KCompressionDevice and QNetworkReply did not work, so I'm adding some tests to confirm that


Diffs (updated)
-----

  autotests/CMakeLists.txt 1b2e819 
  autotests/kcompressiondevicetest.h PRE-CREATION 
  autotests/kcompressiondevicetest.cpp PRE-CREATION 

Diff: https://git.reviewboard.kde.org/r/125941/diff/


Testing
-------

The tests run and show that KCompressionDevice works properly with QBuffer when used with KTar


Thanks,

Romário Rios

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20151125/2dcb4a5f/attachment.html>


More information about the Kde-frameworks-devel mailing list