Review Request 125941: Add KCompressionDevice tests to KArchive

[David Faure]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125941/#review88847
-----------------------------------------------------------

Ship it!


I would have used less member variables in the unittest, but ok nevermind, it's just a test.

Thanks for the test, let's have it in.


autotests/CMakeLists.txt (line 6)
<https://git.reviewboard.kde.org/r/125941/#comment60877>

    This should probably be made optional, it's an unexpected dependency for KArchive.



autotests/kcompressiondevicetest.cpp (line 32)
<https://git.reviewboard.kde.org/r/125941/#comment60878>

    not really needed for this QBuffer-based test, but ok, it's just a first step towards making QNetworkReply work, let's commit what works now.


- David Faure


On Nov. 25, 2015, 3:12 p.m., Romário Rios wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/125941/
> -----------------------------------------------------------
> 
> (Updated Nov. 25, 2015, 3:12 p.m.)
> 
> 
> Review request for KDE Frameworks, Aleix Pol Gonzalez and David Faure.
> 
> 
> Repository: karchive
> 
> 
> Description
> -------
> 
> I recently noticed that using KTar with KCompressionDevice and QNetworkReply did not work, so I'm adding some tests to confirm that
> 
> 
> Diffs
> -----
> 
>   autotests/CMakeLists.txt 1b2e819 
>   autotests/kcompressiondevicetest.h PRE-CREATION 
>   autotests/kcompressiondevicetest.cpp PRE-CREATION 
> 
> Diff: https://git.reviewboard.kde.org/r/125941/diff/
> 
> 
> Testing
> -------
> 
> The tests run and show that KCompressionDevice works properly with QBuffer when used with KTar
> 
> 
> Thanks,
> 
> Romário Rios
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20151125/40169b49/attachment-0001.html>