Review Request 126152: Fly away from QString::isNull() in favor of isEmpty()

Aleix Pol Gonzalez aleixpol at kde.org
Tue Nov 24 15:05:49 UTC 2015


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126152/
-----------------------------------------------------------

(Updated Nov. 24, 2015, 3:05 p.m.)


Status
------

This change has been marked as submitted.


Review request for KDE Frameworks and Chusslove Illich.


Changes
-------

Submitted with commit 9c17965a56b83b3fd34b1eefcd915823ec546f76 by Aleix Pol to branch master.


Repository: ki18n


Description
-------

They don't work and it's a pointless distinction really.


Diffs
-----

  src/klocalizedcontext.cpp 2b6bcf6 

Diff: https://git.reviewboard.kde.org/r/126152/diff/


Testing
-------

Fixes the test. Actually I started getting the same crash as build.kde.org as soon as I started adding qDebugs...


Thanks,

Aleix Pol Gonzalez

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20151124/1abd4732/attachment.html>


More information about the Kde-frameworks-devel mailing list