Review Request 126152: Fly away from QString::isNull() in favor of isEmpty()

Chusslove Illich caslav.ilic at gmx.net
Tue Nov 24 11:45:02 UTC 2015


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126152/#review88755
-----------------------------------------------------------

Ship it!


Ship It!

- Chusslove Illich


On Нов. 24, 2015, 12:57 пре п., Aleix Pol Gonzalez wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126152/
> -----------------------------------------------------------
> 
> (Updated Нов. 24, 2015, 12:57 пре п.)
> 
> 
> Review request for KDE Frameworks and Chusslove Illich.
> 
> 
> Repository: ki18n
> 
> 
> Description
> -------
> 
> They don't work and it's a pointless distinction really.
> 
> 
> Diffs
> -----
> 
>   src/klocalizedcontext.cpp 2b6bcf6 
> 
> Diff: https://git.reviewboard.kde.org/r/126152/diff/
> 
> 
> Testing
> -------
> 
> Fixes the test. Actually I started getting the same crash as build.kde.org as soon as I started adding qDebugs...
> 
> 
> Thanks,
> 
> Aleix Pol Gonzalez
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20151124/184d2705/attachment.html>


More information about the Kde-frameworks-devel mailing list