Review Request 126110: Clean up and armour Baloo::Database::open()

[Boudhayan Gupta]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126110/
-----------------------------------------------------------

(Updated Nov. 24, 2015, 11:42 a.m.)


Status
------

This change has been marked as submitted.


Review request for Baloo, KDE Frameworks, Pinak Ahuja, and Vishesh Handa.


Changes
-------

Submitted with commit 22ade345757b7c080597f5f062b7ebb6e45a2c3d by Boudhayan Gupta to branch master.


Bugs: 353757
    http://bugs.kde.org/show_bug.cgi?id=353757


Repository: baloo


Description
-------

* Add checks for failures
* Add manual checks after Q_ASSERT* (they're not compiled in Release mode)
* Clean up m_env after failure, not just set it to 0


Diffs
-----

  src/engine/database.cpp e39eb86 

Diff: https://git.reviewboard.kde.org/r/126110/diff/


Testing
-------

Builds, runs, does not crash.
make test succeeds at 100%


Thanks,

Boudhayan Gupta

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20151124/bd279081/attachment.html>