Review Request 126110: Clean up and armour Baloo::Database::open()

[Boudhayan Gupta]

> On Nov. 24, 2015, 4:20 p.m., Vishesh Handa wrote:
> > src/engine/database.cpp, line 73
> > <https://git.reviewboard.kde.org/r/126110/diff/1/?file=417424#file417424line73>
> >
> >     Please remove the comment. It's not longer valid.

We still are checking if the index exists and bailing out early if not, but sure, I'll remove the comment.


> On Nov. 24, 2015, 4:20 p.m., Vishesh Handa wrote:
> > src/engine/database.cpp, line 199
> > <https://git.reviewboard.kde.org/r/126110/diff/1/?file=417424#file417424line199>
> >
> >     Perhaps you want to close the env here as well? The assert can fail in production.

Done (in both RW and RO cases).


- Boudhayan


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126110/#review88751
-----------------------------------------------------------


On Nov. 19, 2015, 5:09 p.m., Boudhayan Gupta wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126110/
> -----------------------------------------------------------
> 
> (Updated Nov. 19, 2015, 5:09 p.m.)
> 
> 
> Review request for Baloo, KDE Frameworks, Pinak Ahuja, and Vishesh Handa.
> 
> 
> Bugs: 353757
>     http://bugs.kde.org/show_bug.cgi?id=353757
> 
> 
> Repository: baloo
> 
> 
> Description
> -------
> 
> * Add checks for failures
> * Add manual checks after Q_ASSERT* (they're not compiled in Release mode)
> * Clean up m_env after failure, not just set it to 0
> 
> 
> Diffs
> -----
> 
>   src/engine/database.cpp e39eb86 
> 
> Diff: https://git.reviewboard.kde.org/r/126110/diff/
> 
> 
> Testing
> -------
> 
> Builds, runs, does not crash.
> make test succeeds at 100%
> 
> 
> Thanks,
> 
> Boudhayan Gupta
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20151124/24403cc5/attachment.html>