Review Request 126087: Move the i18n context from KDeclarative

[Aleix Pol Gonzalez]

> On Nov. 20, 2015, 2:33 p.m., Chusslove Illich wrote:
> > src/klocalizedcontext.cpp, line 87
> > <https://git.reviewboard.kde.org/r/126087/diff/4/?file=417454#file417454line87>
> >
> >     How are numbers converted to strings, before being passed here? Because when it receives actual numeric types, KI18n will take care to represent them in locale-specific way. Also it will let translators (through "translation scripting" feature) operate on numbers, e.g. to handle multi-plural cases.
> >     
> >     Is it possible to get back to actual numbers, or the originating data type is irrevocably lost? If not, at least we should document this mungling somewhere.

At the moment it's QML itself doing the conversion and now that you point it out I see how it could be a problem... I'll try if it's possible to use QVariant there instead of QString directly.


- Aleix


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126087/#review88648
-----------------------------------------------------------


On Nov. 19, 2015, 5 p.m., Aleix Pol Gonzalez wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126087/
> -----------------------------------------------------------
> 
> (Updated Nov. 19, 2015, 5 p.m.)
> 
> 
> Review request for KDE Frameworks, Chusslove Illich and Marco Martin.
> 
> 
> Repository: ki18n
> 
> 
> Description
> -------
> 
> The only way to use `i18n*()` so far in QML is by depending on all KDeclarative. This patch moves the necessary bits there so it can be adopted by an application or framework just by offering the needed bits within KI18n.
> This is done by offering an object with methods that map to the `i18n*()` C++ counter-parts.
> 
> 
> Diffs
> -----
> 
>   autotests/CMakeLists.txt 1cf0f7a 
>   autotests/ki18ndeclarativetest.cpp PRE-CREATION 
>   autotests/test.qml PRE-CREATION 
>   docs/programmers-guide.md 13a5f9d 
>   src/CMakeLists.txt 818595e 
>   src/klocalizedcontext.h PRE-CREATION 
>   src/klocalizedcontext.cpp PRE-CREATION 
> 
> Diff: https://git.reviewboard.kde.org/r/126087/diff/
> 
> 
> Testing
> -------
> 
> Ported KDeclarative, everything still seems to work.
> 
> 
> Thanks,
> 
> Aleix Pol Gonzalez
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20151120/b38f0895/attachment-0001.html>