Review Request 126087: Move the i18n context from KDeclarative

[Chusslove Illich]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126087/#review88648
-----------------------------------------------------------



src/klocalizedcontext.h (line 28)
<https://git.reviewboard.kde.org/r/126087/#comment60765>

    ...of KI18n framework in QML?



src/klocalizedcontext.cpp (line 87)
<https://git.reviewboard.kde.org/r/126087/#comment60766>

    How are numbers converted to strings, before being passed here? Because when it receives actual numeric types, KI18n will take care to represent them in locale-specific way. Also it will let translators (through "translation scripting" feature) operate on numbers, e.g. to handle multi-plural cases.
    
    Is it possible to get back to actual numbers, or the originating data type is irrevocably lost? If not, at least we should document this mungling somewhere.



src/klocalizedcontext.cpp (line 145)
<https://git.reviewboard.kde.org/r/126087/#comment60767>

    KI18n plural semantics is to take as plural deciding the first integer-valued argument, which needs not be the first argument. So this should be a loop over all arguments, until first successful conversion. (Of course, better if the originating numeric types can be recovered.)


- Chusslove Illich


On Нов. 19, 2015, 5 по п., Aleix Pol Gonzalez wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126087/
> -----------------------------------------------------------
> 
> (Updated Нов. 19, 2015, 5 по п.)
> 
> 
> Review request for KDE Frameworks, Chusslove Illich and Marco Martin.
> 
> 
> Repository: ki18n
> 
> 
> Description
> -------
> 
> The only way to use `i18n*()` so far in QML is by depending on all KDeclarative. This patch moves the necessary bits there so it can be adopted by an application or framework just by offering the needed bits within KI18n.
> This is done by offering an object with methods that map to the `i18n*()` C++ counter-parts.
> 
> 
> Diffs
> -----
> 
>   autotests/CMakeLists.txt 1cf0f7a 
>   autotests/ki18ndeclarativetest.cpp PRE-CREATION 
>   autotests/test.qml PRE-CREATION 
>   docs/programmers-guide.md 13a5f9d 
>   src/CMakeLists.txt 818595e 
>   src/klocalizedcontext.h PRE-CREATION 
>   src/klocalizedcontext.cpp PRE-CREATION 
> 
> Diff: https://git.reviewboard.kde.org/r/126087/diff/
> 
> 
> Testing
> -------
> 
> Ported KDeclarative, everything still seems to work.
> 
> 
> Thanks,
> 
> Aleix Pol Gonzalez
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20151120/d44dff4b/attachment.html>