Review Request 126009: [KUrlNavigator] Fix url encoding problems in KUrlNavigator

Emmanuel Pescosta emmanuelpescosta099 at gmail.com
Mon Nov 9 22:15:26 UTC 2015


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126009/
-----------------------------------------------------------

(Updated Nov. 9, 2015, 10:15 p.m.)


Status
------

This change has been marked as submitted.


Review request for KDE Frameworks and David Faure.


Changes
-------

Submitted with commit 9dbe36f734b5b839b2a6a934fad29d639e954498 by Emmanuel Pescosta to branch master.


Bugs: 354678
    https://bugs.kde.org/show_bug.cgi?id=354678


Repository: kio


Description
-------

Fix url encoding problems (e.g. when the path contains a '%') in KUrlNavigator

These changes also fix a weird behavior of KUrlNavigator when button 0 is
pressed. KUrlNavigator always used the local path '/' for button 0 and ignored
the scheme and authority. The networkPathButtonIndex* and ftpPathButtonIndex*
test rows test exactly this problem.


Diffs
-----

  autotests/kurlnavigatortest.h e65e8ef 
  autotests/kurlnavigatortest.cpp 25d1ed6 
  src/filewidgets/kurlnavigator.cpp 28d750e 

Diff: https://git.reviewboard.kde.org/r/126009/diff/


Testing
-------

All tests pass


Thanks,

Emmanuel Pescosta

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20151109/5affdb45/attachment.html>


More information about the Kde-frameworks-devel mailing list