Review Request 126009: [KUrlNavigator] Fix url encoding problems in KUrlNavigator

David Faure faure at kde.org
Mon Nov 9 20:46:29 UTC 2015


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126009/#review88203
-----------------------------------------------------------

Ship it!


Ship It!

- David Faure


On Nov. 9, 2015, 7:09 p.m., Emmanuel Pescosta wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126009/
> -----------------------------------------------------------
> 
> (Updated Nov. 9, 2015, 7:09 p.m.)
> 
> 
> Review request for KDE Frameworks and David Faure.
> 
> 
> Bugs: 354678
>     https://bugs.kde.org/show_bug.cgi?id=354678
> 
> 
> Repository: kio
> 
> 
> Description
> -------
> 
> Fix url encoding problems (e.g. when the path contains a '%') in KUrlNavigator
> 
> These changes also fix a weird behavior of KUrlNavigator when button 0 is
> pressed. KUrlNavigator always used the local path '/' for button 0 and ignored
> the scheme and authority. The networkPathButtonIndex* and ftpPathButtonIndex*
> test rows test exactly this problem.
> 
> 
> Diffs
> -----
> 
>   autotests/kurlnavigatortest.h e65e8ef 
>   autotests/kurlnavigatortest.cpp 25d1ed6 
>   src/filewidgets/kurlnavigator.cpp 28d750e 
> 
> Diff: https://git.reviewboard.kde.org/r/126009/diff/
> 
> 
> Testing
> -------
> 
> All tests pass
> 
> 
> Thanks,
> 
> Emmanuel Pescosta
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20151109/c85ccf12/attachment-0001.html>


More information about the Kde-frameworks-devel mailing list