Review Request 123861: Make KCodecs::base64Encode() RFC compliant
Aleix Pol Gonzalez
aleixpol at kde.org
Wed May 20 13:27:44 UTC 2015
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/123861/#review80663
-----------------------------------------------------------
+1
- Aleix Pol Gonzalez
On May 20, 2015, 2:46 p.m., Daniel Vrátil wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/123861/
> -----------------------------------------------------------
>
> (Updated May 20, 2015, 2:46 p.m.)
>
>
> Review request for KDE Frameworks.
>
>
> Repository: kcodecs
>
>
> Description
> -------
>
> Don't append a trailing CRLF to the coded data. This was left over from KMime, where this made some sense in respect to RFC822.
>
> According to LXR it should not affect anything except for some unreleased KDE PIM code and it will fix code that expects the original behaviour.
>
>
> Diffs
> -----
>
> src/kcodecsbase64.cpp fc03262
>
> Diff: https://git.reviewboard.kde.org/r/123861/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Daniel Vrátil
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20150520/6dcd0bac/attachment-0001.html>
More information about the Kde-frameworks-devel
mailing list