Review Request 123861: Make KCodecs::base64Encode() RFC compliant

Daniel Vrátil dvratil at kde.org
Wed May 20 12:46:52 UTC 2015


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/123861/
-----------------------------------------------------------

Review request for KDE Frameworks.


Repository: kcodecs


Description
-------

Don't append a trailing CRLF to the coded data. This was left over from KMime, where this made some sense in respect to RFC822.

According to LXR it should not affect anything except for some unreleased KDE PIM code and it will fix code that expects the original behaviour.


Diffs
-----

  src/kcodecsbase64.cpp fc03262 

Diff: https://git.reviewboard.kde.org/r/123861/diff/


Testing
-------


Thanks,

Daniel Vrátil

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20150520/e09e117e/attachment.html>


More information about the Kde-frameworks-devel mailing list